Change in vdsm[master]: events: vm status notifications

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Thu Apr 9 14:32:56 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: events: vm status notifications
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38937/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1524:         if not guestCpuLocked:
Line 1525:             self._acquireCpuLockWithTimeout()
Line 1526:         try:
Line 1527:             self._guestCpuRunning = isRunning
Line 1528:             if (not self._guestCpuRunning and
looking deeper in clientIF there is another place in watchdog handler...it doesn't call this, it probably should...or it should fire the event. Not sure if that thing is relevant/used

state tracking probably needs a bit more refactoring before we can use it for events
Line 1529:                     self._lastStatus in vmstatus.PAUSED_STATES):
Line 1530:                 self.cif.notify('|virt|VM_status|' + self.id,
Line 1531:                                 **{self.id: 'Paused'})
Line 1532:         finally:


-- 
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list