Change in vdsm[master]: hsm: Add refresh device verb

nsoffer at redhat.com nsoffer at redhat.com
Thu Apr 9 13:57:13 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: Add refresh device verb
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/38754/15/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 1488: # Since: 4.17.0
Line 1489: ##
Line 1490: {'command': {'class': 'Host', 'name': 'refreshDevice'},
Line 1491:  'data': {'guid': ['UUID']},
Line 1492:   'returns': 'long'}
> Please keep it inline.
I don't see any other api using 'long' - use what Adam suggested.
Line 1493: 
Line 1494: ##
Line 1495: # @DeviceVisibilityMap:
Line 1496: #


-- 
To view, visit https://gerrit.ovirt.org/38754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list