Change in vdsm[ovirt-3.5]: iscsi: Fix iscsi_host path lookup for hardware iSCSI.

ybronhei at redhat.com ybronhei at redhat.com
Wed Apr 8 14:33:30 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: iscsi: Fix iscsi_host path lookup for hardware iSCSI.
......................................................................


iscsi: Fix iscsi_host path lookup for hardware iSCSI.

In commit a78793935e (Configure iSCSI iface.net_ifacename), we
introduced the iface.net_ifacename probe for active sessions. We use
the sessionID to locate /sys/class/iscs_host/host* and read the
netdev attribue.

However, we looked up the session in /sys/devices/platform/host*
which is correct only for software iSCSI. For hardware iSCSI, the
session is located in /sys/devices/pci*/*/*/*/host*.
This patch locates the host using the real iscsi_session path, which
works for both software and hardware iSCSI.

Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Bug-Url: https://bugzilla.redhat.com/1209108
Signed-off-by: Amador Pahim <apahim at redhat.com>
Signed-off-by: Amit Aviram  <aaviram at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38354
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39555
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/storage/iscsi.py
1 file changed, 14 insertions(+), 6 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Federico Simoncelli: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/39555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list