Change in vdsm[ovirt-3.5]: spec: Update libvirt-daemon and libvirt-python requirements

nsoffer at redhat.com nsoffer at redhat.com
Wed Apr 8 11:51:25 UTC 2015


Hello Adam Litke, Federico Simoncelli, Allon Mureinik,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/39671

to review the following change.

Change subject: spec: Update libvirt-daemon and libvirt-python requirements
......................................................................

spec: Update libvirt-daemon and libvirt-python requirements

The errata RHBA-2015:0742-05 fixes bug 1177220 by updating libvirt to
version 1.2.8-16.el7_1.2.  Details from the advisory follow:

When using the QEMU emulator to search for a file name in a backing
chain, QEMU previously searched for an incorrect string. As a
consequence, QEMU was unable to perform blockpull and blockcommit
actions involving the affected part of the backing chain. With this
update, libvirt queries the QEMU version of the string associated with a
backing chain element. As a result, it is now possible to create
multiple snapshots and then use consecutive blockcommit actions to clear
the snapshots. (Bug 1203119)

In order to resolve the problems with live merge we must require this
version of libvirt on EL7 hosts. On Fedora this fix is available only in
1.2.14, which available only on Fedora 22. When running on Fedora < 22,
we don't have any fix yet to this issue.

This version of libvirt also includes a fix for LSM (Bug 1176673). The
libvirt flag VIR_DOMAIN_BLOCK_REBASE_COPY_DEV was added to libvirt and
the python bindings and will be used by vdsm to make sure block disks
are handled properly by libvirt.  We need both libvirt-daemon >=
1.2.8-16.el7_1.1 and libvirt-python >= 1.2.8-7.el7_1.1 for a complete
fix to the problem.

Note that we can require new libvirt-daemon only when when building
RHEV, since our CI is still using Centos 7.0.

Change-Id: I571cc86e0f478b4169f398a6d54c96fc8bb4da30
Bug-Url: https://bugzilla.redhat.com/1158563
Bug-Url: https://bugzilla.redhat.com/1176673
Signed-off-by: Adam Litke <alitke at redhat.com>
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39551
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm.spec.in
1 file changed, 18 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/39671/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 4ae9f5b..a6ec581 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -179,18 +179,31 @@
 %endif
 
 %if 0%{?rhel} >= 7
-Requires: libvirt-daemon >= 1.0.2-1
-%endif
+%if 0%{?rhev_build}
+Requires: libvirt-daemon >= 1.2.8-16.el7_1.2
+Requires: libvirt-python >= 1.2.8-7.el7_1.1
+%else
+Requires: libvirt-daemon >= 1.2.8-15.el7
+Requires: libvirt-python
+%endif # rhev_build
+%endif # rhel 7
 
 %if 0%{?rhel} == 6
 Requires: libvirt >= 0.10.2-29.el6_5.4
+Requires: libvirt-python
 %endif
 
-%if 0%{?fedora}
-Requires: libvirt-daemon >= 1.0.2-1
+%if 0%{?fedora} >= 22
+Requires: libvirt-daemon >= 1.2.14
+Requires: libvirt-python
 %endif
 
-Requires: libvirt-python, libvirt-lock-sanlock, libvirt-client
+%if 0%{?fedora} && 0%{?fedora} <= 21
+Requires: libvirt-daemon >= 1.2.9
+Requires: libvirt-python
+%endif
+
+Requires: libvirt-lock-sanlock, libvirt-client
 
 # iscsi-intiator versions
 %if 0%{?rhel}


-- 
To view, visit https://gerrit.ovirt.org/39671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I571cc86e0f478b4169f398a6d54c96fc8bb4da30
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list