Change in vdsm[master]: vm: hyperv: support all the libvirt optimizations
mpolednik at redhat.com
mpolednik at redhat.com
Wed Apr 8 09:08:40 UTC 2015
Martin Polednik has posted comments on this change.
Change subject: vm: hyperv: support all the libvirt optimizations
......................................................................
Patch Set 12: Code-Review-1
(2 comments)
I don't understand where did the "track" attribute go
https://gerrit.ovirt.org/#/c/29234/12/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 190: else:
Line 191: clockName = 'rtc'
Line 192:
Line 193: # 'hypervclock' does not support the 'track' attribute.
Line 194: # libvirt docs is not very clear here.
are* :) Also, where did the track attribute go then? This is clearly correct for hypervclock, but "track='guest'" is missing for rtc?
Line 195: m = Element('clock', offset='variable',
Line 196: adjustment=str(self.conf.get('timeOffset', 0)))
Line 197: m.appendChildWithArgs('timer', name=clockName, tickpolicy='catchup')
Line 198: m.appendChildWithArgs('timer', name='pit', tickpolicy='delay')
Line 307: features.appendChildWithArgs('acpi')
Line 308:
Line 309: if utils.tobool(self.conf.get('hypervEnable', 'false')):
Line 310: # performance optimization flags, that can improve the performance
Line 311: # by 10% to much more (in extreme cases of resources overcommit).
Any reference?
Line 312: hyperv = Element('hyperv')
Line 313: features.appendChild(hyperv)
Line 314:
Line 315: hyperv.appendChildWithArgs('relaxed', state='on')
--
To view, visit https://gerrit.ovirt.org/29234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia10cb4ce254b6e6f560c045aff9e68846fe4771f
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list