Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [2/2]

danken at redhat.com danken at redhat.com
Tue Apr 7 15:42:40 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: betterAsyncore: Fix event loop data stealing [2/2]
......................................................................


betterAsyncore: Fix event loop data stealing [2/2]

In this patch we override asyncore.dispatcher.del_channel() and set
dispatcher.connected to False after a dispather was removed from the
event loop. This breaks out of the pending data read loop in
Dispatcher.handle_read_event().

Change-Id: I5978b58ed47b7a3836f19b3b40fe857e43f76bae
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39514
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/39514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5978b58ed47b7a3836f19b3b40fe857e43f76bae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list