Change in vdsm[master]: xmlrpc: fd leak on centos7

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Apr 7 13:27:07 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: xmlrpc: fd leak on centos7
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/39506/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-04-03 09:38:49 +0200
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2015-04-03 09:38:49 +0200
Line 6: 
Line 7: xmlrpc: fd leak on centos7
> Are you sure this is relevant only to centos 7? please explain how.
It was found on centos. I agree that is confusing.
Line 8: 
Line 9: We found that when running functional test networkTests we are leaking
Line 10: fds. Each seperate call ends with 1 fd not released. After long
Line 11: investigation I noticed that the leak was caused by not closing plain


Line 9: We found that when running functional test networkTests we are leaking
Line 10: fds. Each seperate call ends with 1 fd not released. After long
Line 11: investigation I noticed that the leak was caused by not closing plain
Line 12: socket wrapped by ssl socket. Calling shutdown and close on ssl do not
Line 13: closes plain socket.
> This may be a leak in the functional network tests, which is not interestin
Francesco saw it running vdsClient.

Sure will add this info to commit message.
Line 14: 
Line 15: 
Line 16: Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49


-- 
To view, visit https://gerrit.ovirt.org/39506
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list