Change in vdsm[master]: vm: hyperv: support all the libvirt optimizations

fromani at redhat.com fromani at redhat.com
Tue Apr 7 12:46:47 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: hyperv: support all the libvirt optimizations
......................................................................


Patch Set 11:

(3 comments)

https://gerrit.ovirt.org/#/c/29234/11/vdsm.spec.in
File vdsm.spec.in:

Line 223: Requires: lvm2
Line 224: Requires: python
Line 225: Requires: policycoreutils-python
Line 226: Requires: selinux-policy-targeted >= selinux-policy-3.13.1-16.el7
Line 227: Requires: qemu-kvm-rhev >= 1.5.3-60.el7
> how about moving this to the section at line 267. If they are all needed
Bad rebase. Will fix.
Line 228: Requires: qemu-img-rhev >= 1.5.3-60.el7
Line 229: %else
Line 230: Requires: python
Line 231: Requires: device-mapper-multipath >= 0.4.9-52


https://gerrit.ovirt.org/#/c/29234/11/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 189:             clockName = 'hypervclock'
Line 190:         else:
Line 191:             clockName = 'rtc'
Line 192: 
Line 193:         # 'hypervclock' does not support the 'track' attribute.
> so where did it go for non-hyperv?
track='guest' should have been enabled only if hypervEnable=false, so it should be fine
Line 194:         # libvirt docs is not very clear here.
Line 195:         m = Element('clock', offset='variable',
Line 196:                     adjustment=str(self.conf.get('timeOffset', 0)))
Line 197:         m.appendChildWithArgs('timer', name=clockName, tickpolicy='catchup')


Line 315:             # some high load BSODs.
Line 316:             hyperv.appendChildWithArgs('vapic', state='on')
Line 317:             hyperv.appendChildWithArgs(
Line 318:                 'spinlocks', state='on', retries='8191')
Line 319:             # performance optimization flags, that can improve the performance
> shouldn't it be above 316? or does it relate to the whole section?
will move.
Line 320:             # by 10% to much more (in extreme cases of resources overcommit).
Line 321: 
Line 322:     def appendCpu(self):
Line 323:         """


-- 
To view, visit https://gerrit.ovirt.org/29234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia10cb4ce254b6e6f560c045aff9e68846fe4771f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list