Change in vdsm[master]: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API

Federico Simoncelli fsimonce at redhat.com
Tue Apr 7 11:23:29 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38421/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3003:                 try:
Line 3004:                     pvInfo = lvm.getPV(pv)
Line 3005:                 except se.InaccessiblePhysDev:
Line 3006:                     self.log.error("PV %s no longer exists", pv)
Line 3007:                     continue
> Previously the entire request was failing with AttributeError, now the requ
The problem here is not about swallowing the ugly exception, it's that we don't want to feed partial/incomplete information to engine. So, in a sense failing hard was better than letting believe the engine that the VG was fine with just those luns.

Nir, can we easily add a patch on top of this that gives feedback to the engine about the messing pv?
Line 3008:                 vgInfo['pvlist'].append(self.__fillPVDict(dev, pvInfo, vgType))
Line 3009: 
Line 3010:             if vgType == multipath.DEV_FCP:
Line 3011:                 vgType = sd.FCP_DOMAIN


-- 
To view, visit https://gerrit.ovirt.org/38421
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I583c0493093d2c9c8bca8713df8ee123c415de7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list