Change in vdsm[master]: Cache the result of numaUtils.getVcpuPids

fromani at redhat.com fromani at redhat.com
Tue Apr 7 10:18:06 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: Cache the result of numaUtils.getVcpuPids
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38564/3/vdsm/numaUtils.py
File vdsm/numaUtils.py:

Line 47:     path = _libvirt_xml_path(vmName)
Line 48:     mtime = os.path.getmtime(path)
Line 49: 
Line 50:     if path in _libvirt_vcpu_pids_cache:
Line 51:         lastmtime, value = _libvirt_vcpu_pids_cache[path]
> Indeed, but aren't we stopping the stats threads before we cleanup a VM? Ad
we are, but onQemuDeath can be fired anytime.
Indeed most likely if QEMU dies outside our control we have much bigger problems, but still worth a check (or at least a comment here).
Line 52:         if lastmtime == mtime:
Line 53:             return value
Line 54: 
Line 55:     runInfo = ET.parse(path)


-- 
To view, visit https://gerrit.ovirt.org/38564
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I135143bccdd29697ec673819212193c0fc217e56
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list