Change in vdsm[master]: vdsm-tool: Remove unneeded imp import

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 7 09:59:14 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vdsm-tool: Remove unneeded imp import
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39553/1/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:

Line 31: # Hack for vdsm-4.16.x installation
Line 32: # To avoid import vdsm-tool verbs from old location (/usr/lib64) on
Line 33: # upgrade we need to explicit import vdsm.tool from /usr/lib. Otherwise
Line 34: # all tool's verbs are loaded from the old vdsm code during upgrade.
Line 35: import imp
> Can you remove this? imp should be officially imported (it's not for the ha
Done
Line 36: lib_dir = os.path.join(os.path.dirname(os.__file__).
Line 37:                        replace('lib64', 'lib'), 'site-packages')
Line 38: vdsm = imp.load_module('vdsm', *imp.find_module('vdsm', [lib_dir]))
Line 39: vdsm.tool = imp.load_module('vdsm.tool',


-- 
To view, visit https://gerrit.ovirt.org/39553
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59916f7a199d052af71de7e11f9af9f9e31a5afa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list