Change in vdsm[master]: storage: introducing vdsm-tool dump-volume-chains

ybronhei at redhat.com ybronhei at redhat.com
Mon Apr 6 12:07:32 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: storage: introducing vdsm-tool dump-volume-chains
......................................................................


Patch Set 17:

(3 comments)

https://gerrit.ovirt.org/#/c/38281/17/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 19: from __future__ import print_function
Line 20: import errno
Line 21: import argparse
Line 22: import socket
Line 23: from collections import defaultdict
some might say that the import list needs to be sorted
Line 24: 
Line 25: from . import expose
Line 26: 
Line 27: from vdsm import vdscli


Line 111:     parser = argparse.ArgumentParser()
Line 112:     parser.add_argument('sd_uuid', help="storage domain UUID")
Line 113:     parser.add_argument('-u', '--unsecured', action='store_false',
Line 114:                         dest='use_ssl', default=True,
Line 115:                         help="use unsecured connection")
shouldn't dest be - no_ssl ?
Line 116:     parser.add_argument('-H', '--host', default=vdscli.ADDRESS)
Line 117:     parser.add_argument('-p', '--port', default=vdscli.PORT)
Line 118: 
Line 119:     return parser.parse_args(args=args[1:])


https://gerrit.ovirt.org/#/c/38281/17/vdsm.spec.in
File vdsm.spec.in:

Line 1347: %{python_sitelib}/%{vdsm_name}/tool/upgrade_300_networks.py*
Line 1348: %{python_sitelib}/%{vdsm_name}/tool/validate_ovirt_certs.py*
Line 1349: %{python_sitelib}/%{vdsm_name}/tool/vdsm-id.py*
Line 1350: %{python_sitelib}/%{vdsm_name}/tool/dump_volume_chains.py*
Line 1351: 
this should be in alphabetic order
Line 1352: %files tests
Line 1353: %doc %{_datadir}/%{vdsm_name}/tests/README
Line 1354: %defattr(-, root, root, -)
Line 1355: %dir %{_datadir}/%{vdsm_name}/tests


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list