Change in vdsm[master]: storage: introducing vdsm-tool dump-volume-chains

ibarkan at redhat.com ibarkan at redhat.com
Mon Apr 6 07:30:07 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: storage: introducing vdsm-tool dump-volume-chains
......................................................................


Patch Set 15:

(5 comments)

https://gerrit.ovirt.org/#/c/38281/15//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-03-19 10:12:17 +0200
Line 4: Commit:     Ido Barkan <ibarkan at redhat.com>
Line 5: CommitDate: 2015-04-05 09:32:40 +0300
Line 6: 
Line 7: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
> This is actually "Introducing vdsm-tool dump-volume-chains"
Done
Line 8: 
Line 9: This script queries VDSM about the existing structure of image
Line 10: volumes and prints them in an ordered fashion with optional
Line 11: additional info per volume.


Line 5: CommitDate: 2015-04-05 09:32:40 +0300
Line 6: 
Line 7: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
Line 8: 
Line 9: This script queries VDSM about the existing structure of image
> This script -> This command
Done
Line 10: volumes and prints them in an ordered fashion with optional
Line 11: additional info per volume.
Line 12: 
Line 13: Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404


Line 6: 
Line 7: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
Line 8: 
Line 9: This script queries VDSM about the existing structure of image
Line 10: volumes and prints them in an ordered fashion with optional
> Remove "optional"
Done
Line 11: additional info per volume.
Line 12: 
Line 13: Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404


https://gerrit.ovirt.org/#/c/38281/15/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 206:     print('Images volume chains (base volume first)')
Line 207:     for img_uuid, vol_chain in image_chains.iteritems():
Line 208:         print('')
Line 209:         _print_line(img_uuid, 'image:')
Line 210: 
> An empty line here will make the output more clear.
Done
Line 211:         if isinstance(vol_chain, ChainError):
Line 212:             chain_err = vol_chain
Line 213:             _print_line(chain_err.description)
Line 214:             _print_line('Volumes and children:')


Line 222:                 _print_line('- ' + vol)
Line 223:                 try:
Line 224:                     _print_vol_info(volumes_info[vol])
Line 225:                 except KeyError:
Line 226:                     _print_line("no volume info for volume %s" % (vol,))
> I think this is not possible like in the chain error code path. For each vo
right
Line 227:                 print('')
Line 228: 
Line 229: 
Line 230: def _print_vol_info(volume_info):


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list