Change in vdsm[master]: spec: Simplify libvirt dependencies

nsoffer at redhat.com nsoffer at redhat.com
Sun Apr 5 12:58:24 UTC 2015


Hello Adam Litke,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/39543

to review the following change.

Change subject: spec: Simplify libvirt dependencies
......................................................................

spec: Simplify libvirt dependencies

We had complicated if else mess that makes it hard to understand, and
impossible to require the right version for each supported platform.

Now we have a rule for each platform version, and we can just remove the
rule when we stop supporting a platform, without breaking anything else.

Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Relates-To: https://bugzilla.redhat.com/1158563
Relates-To: https://bugzilla.redhat.com/1176673
Signed-off-by: Adam Litke <alitke at redhat.com>
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm.spec.in
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/39543/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index ec0b377..e03cefd 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -191,15 +191,19 @@
 Requires: libvirt-daemon-driver-nwfilter
 Requires: libvirt-daemon-driver-qemu
 %endif
-%if 0%{?rhel}
+
 %if 0%{?rhel} >= 7
 Requires: libvirt-daemon >= 1.2.8-15.el7
-%else
+%endif
+
+%if 0%{?rhel} == 6
 Requires: libvirt >= 0.10.2-29.el6_5.4
-%endif # rhel 7
-%else # fedora
+%endif
+
+%if 0%{?fedora} >= 20
 Requires: libvirt >= 1.2.9
 %endif
+
 Requires: libvirt-python, libvirt-lock-sanlock, libvirt-client
 
 # iscsi-intiator versions


-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>


More information about the vdsm-patches mailing list