Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...

ibarkan at redhat.com ibarkan at redhat.com
Sun Apr 5 07:46:04 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks)
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/39387/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-03-31 11:42:29 +0200
Line 4: Commit:     Ondřej Svoboda <osvoboda at redhat.com>
Line 5: CommitDate: 2015-03-31 12:02:05 +0200
Line 6: 
Line 7: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks)
Maybe add a short description on _why_ you do it (so it should be installed always)
Line 8: 
Line 9: Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d


https://gerrit.ovirt.org/#/c/39387/2/vdsm_hooks/Makefile.am
File vdsm_hooks/Makefile.am:

Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: SUBDIRS = \
nit: separate commit? you reformat and update the code here
Line 22: 	ethtool_options \
Line 23: 	faqemu \
Line 24: 	ipv6 \
Line 25: 	macspoof \


-- 
To view, visit https://gerrit.ovirt.org/39387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list