Change in vdsm[master]: Revert "tests: making as broken"

nsoffer at redhat.com nsoffer at redhat.com
Fri Apr 3 14:54:34 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: Revert "tests: making as broken"
......................................................................

Revert "tests: making as broken"

Some scheduler tests were marked as broken without any explanation, and
without consutling the author of the tests and the code they test.

If tests start to break, we should find the root cause and fix it, not
disbale the tests.

This reverts commit 1db6e0419d6afacdee63aa83264848a93d63b9de.

Change-Id: I72f47032ef99e20f77bad9ecd582c9bdd8298ac6
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M tests/scheduleTests.py
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/39520/1

diff --git a/tests/scheduleTests.py b/tests/scheduleTests.py
index 4a5e52f..2774dda 100644
--- a/tests/scheduleTests.py
+++ b/tests/scheduleTests.py
@@ -24,7 +24,7 @@
 from vdsm import schedule
 from vdsm import utils
 from testlib import VdsmTestCase
-from testValidation import slowtest, brokentest
+from testValidation import slowtest
 from testlib import permutations, expandPermutations
 
 
@@ -94,7 +94,6 @@
         task.wait(delay + self.GRACETIME)
         self.assertEquals(task.call_time, None)
 
-    @brokentest
     @permutations(PERMUTATIONS)
     def test_cancel_call_many(self, clock):
         self.create_scheduler(clock)
@@ -121,7 +120,6 @@
         task.wait(delay + self.GRACETIME)
         self.assertEquals(task.call_time, None)
 
-    @brokentest
     @permutations(PERMUTATIONS)
     def test_stop_scheduler_many(self, clock):
         self.create_scheduler(clock)


-- 
To view, visit https://gerrit.ovirt.org/39520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I72f47032ef99e20f77bad9ecd582c9bdd8298ac6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list