Change in vdsm[master]: v2v: Job related actions

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri Apr 3 11:38:23 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: v2v: Job related actions
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/39361/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 172: def get_converted_vm(job_id):
Line 173:     try:
Line 174:         job = _get_job(job_id)
Line 175:         _validate_job_done(job)
Line 176:         ovf = _read_ovf(job_id)
> _validate_job_done is relevant only if we have such job. If we don't, we ca
well I do want to clean up the whole temp dir including ovfs on vdsm startup, so there's no chance that there is an ovf file without job (perhaps only corner cases like permission issues)
I would rather not try to return something vdsm is not aware of
Line 177:     except ClientError as e:
Line 178:         logging.info('Converted VM error %s', e)
Line 179:         return errCode[e.err_name]
Line 180:     except V2VError as e:


-- 
To view, visit https://gerrit.ovirt.org/39361
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list