Change in vdsm[master]: v2v: Job related actions

shavivi at redhat.com shavivi at redhat.com
Thu Apr 2 12:06:55 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: v2v: Job related actions
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.ovirt.org/#/c/39361/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 80
Line 81
Line 82
Line 83
Line 84
> Base class for client errors
Done


Line 101
Line 102
Line 103
Line 104
Line 105
> This is a client error - lets change it here.
Done


Line 172: def get_converted_vm(job_id):
Line 173:     try:
Line 174:         job = _get_job(job_id)
Line 175:         _validate_job_done(job)
Line 176:         ovf = _read_ovf(job_id)
> We should change the job_done check like this:
We don't want job that is not done.
If we are after crush we will start over since we want to clean /var/vdsm/v2v directory after vdsm starting.
we don't want to wait to job for finishing (blocking) if not done we are raising an error
Line 177:     except ClientError as e:
Line 178:         logging.info('Converted VM error %s', e)
Line 179:         return errCode[e.err_name]
Line 180:     except V2VError as e:


Line 199:         job = _get_job(job_id)
Line 200:         job.abort()
Line 201:         _remove_job(job_id)
Line 202:     except ClientError as e:
Line 203:         logging.info('Error aboring job: %s, error: %s', job_id, e)
> Error aborting -> Cannot abort job
Done
Line 204:         return errCode[e.err_name]
Line 205:     return {'status': doneCode}
Line 206: 
Line 207: 


-- 
To view, visit https://gerrit.ovirt.org/39361
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list