Change in vdsm[master]: events: vm status notifications

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Thu Apr 2 10:46:41 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: events: vm status notifications
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

+1 for the direction this patch takes is good
-1 for visibility as we dont' want to merge this without message throttling

https://gerrit.ovirt.org/#/c/38937/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1578:             self._guestCpuRunning = isRunning
Line 1579:             if (not self._guestCpuRunning and
Line 1580:                     self._lastStatus in vmstatus.PAUSED_STATES):
Line 1581:                 self.cif.notify('|virt|VM_status|' + self.id,
Line 1582:                                 **{self.id: 'Paused'})
I think we should move/refactor this to have a sync between setting _lastStatus and what we send to engine.

By a brief look it may make sense to move the _lastStatus change here into _setGuestCpuRunning, so then we will have a generic (and correct) event on line 827
Line 1583:         finally:
Line 1584:             if not guestCpuLocked:
Line 1585:                 self._guestCpuLock.release()
Line 1586: 


Line 5011:             self.log.warning('monitor become unresponsive'
Line 5012:                              ' (command timeout, age=%s)',
Line 5013:                              statsAge)
Line 5014:             stats['monitorResponse'] = '-1'
Line 5015:             self.cif.notify('|virt|VM_status|' + self.id,
I think the same applies here
Line 5016:                             **{self.id: 'NotResponding'})
Line 5017: 
Line 5018: 
Line 5019: class LiveMergeCleanupThread(threading.Thread):


-- 
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list