Change in vdsm[ovirt-3.5]: Hack to fix vdsm-tool import issues during upgrade

nsoffer at redhat.com nsoffer at redhat.com
Wed Apr 1 15:20:57 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/39408/5/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:

Line 50: sys.path.pop(0)
Line 51: sys.path.pop(0)
Line 52: 
Line 53: ########################################################################
Line 54: 
> that way you load all under lib/vdsm .. anyway to avoid that with imp? I do
With imp, you will have to import all the modules manually, or write a helper
for loading nested modules (e.g, a.b.c).

For example, to load a.b.c - you need to:
- load a
- load b and set a.b
- load c and set a.b.c

I don't think that we want to go so far. Importing one module to avoid temporary
issue on upgrade is ok.
Line 55: tool_modules = []
Line 56: tool_command = {}
Line 57: 
Line 58: ERROR_SAME_COMMAND = """\


-- 
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list