Change in vdsm[master]: functional tests: add basic device verification

fromani at redhat.com fromani at redhat.com
Wed Apr 1 12:07:31 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: functional tests: add basic device verification
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/38980/4/tests/devices.py
File tests/devices.py:

Line 23: 
Line 24: def verify(device_conf=None, device_objects=None,
Line 25:            assert_in_fn=lambda *_: False,
Line 26:            assert_true_fn=lambda *_: False,
Line 27:            assert_equal_fn=lambda *_: False):
> Having them here allows us to warn (by failing the test) of the missing imp
Sure thing.

First let me clarify: do we actually need defaults for device_conf and device_objects? IMHO is clearer without them, because we'll always need to have both to do meaningful verification (don't we?)

About naming, I'm afraid is just a matter of personal taste, I can't pinpoint a single 'needs to be improved' thing.

I still need we should somehow mimic TestCase interface, but I understood
- passing around TestCaseBase lead to nasty failures, which are out of scope of this patch
- a wrapper object is debatable and probably overkill,

so I'll dont mind anymore about assert_*_fn.
Line 28:     if device_conf is not None:
Line 29:         aliases = []
Line 30:         for device in device_conf:
Line 31:             # Graphics device is a bit specific in a sense that it doesn't


-- 
To view, visit https://gerrit.ovirt.org/38980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88ca6630ad047fbc1d9b036e1112bf5db41dc24d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list