Change in vdsm[master]: volume: Log the correct error when creating a volume fails

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 30 15:38:43 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: volume: Log the correct error when creating a volume fails
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33301/1/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 435:                                      srcVolUUID, volPath)
Line 436:             except (se.VolumeAlreadyExists, se.CannotCreateLogicalVolume) as e:
Line 437:                 cls.log.error("Failed to create volume %s: %s", volPath, e)
Line 438:                 vars.task.popRecovery()
Line 439:                 raise e
> if you are already touching this code, then it will be a good to use only '
I will handle it in another patch.
Line 440:             # When the volume format is raw what the guest sees is the apparent
Line 441:             # size of the file/device therefore if the requested size doesn't
Line 442:             # match the apparent size (eg: physical extent granularity in LVM)
Line 443:             # we need to update the size value so that the metadata reflects


-- 
To view, visit http://gerrit.ovirt.org/33301
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list