Change in vdsm[ovirt-3.5]: addNetwork script: Prevent empty bond and vlan from reaching...

ybronhei at redhat.com ybronhei at redhat.com
Tue Sep 30 14:45:44 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig
......................................................................


addNetwork script: Prevent empty bond and vlan from reaching RunningConfig

The consumers of the addNetwork script pass empty parameters, e.g. ""
in order to fill the positional arguments that the script takes. The
problem with that is that those parameters were being passed to
addNetwork without modification, and that includes the
_alterNetworkConfig wrapper that makes addNetwork requests reach
runningConfig (and eventually PersistentConfig).

Due to the issue above, a stored network could contain entries like
'bonding': '' and 'vlan': '' that would mess with selective network
restoration.

Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3
Bug-Url: https://bugzilla.redhat.com/1144639
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33542
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M vdsm/network/api.py
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33542
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list