Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...

danken at redhat.com danken at redhat.com
Tue Sep 30 12:57:34 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates
......................................................................


vdsm_reg: Make vdsm-reg persist the management bridge it creates

In the vdsm_reg flow, for the oVirt node, the management bridge is
created using addNetworks. This puts the management network in the
RunningConfig ( /var/run/vdsm/netconf/nets ). Then it notifies the
engine of the registration request.

When the engine approves the request, it starts the deployment, part
of which is to start vdsmd. In the common init tasks of vdsmd there is
the restore_nets task that, if /var/run/vdsm/nets_restored does not
exist, it will clear all the networks in RunningConfig and configure
again those in PersistentConfig. The issue is that in a clean
installation there won't be any PersistentConfig, and thus the system
will lose connectivity.

In order to solve this issue, the best course of action is to persist
RunningConfig as PersistentConfig as soon as the management network
has been created by vdsm-reg (and strictly before the registration
request is sent to the engine).

Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Bug-Url: https://bugzilla.redhat.com/1144639
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33411
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Tested-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M vdsm_reg/deployUtil.py.in
1 file changed, 21 insertions(+), 2 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list