Change in vdsm[master]: virt: sampling: more cautious disk stats check

fromani at redhat.com fromani at redhat.com
Tue Sep 30 11:20:02 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: sampling: more cautious disk stats check
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/33482/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 538:                 if isVdsmImage(vmDrive):
Line 539:                     dStats['imageID'] = vmDrive.imageID
Line 540:                 elif "GUID" in vmDrive:
Line 541:                     dStats['lunGUID'] = vmDrive.GUID
Line 542:                 if sInfo is not None and eInfo is not None and (
> Just to make sure we are not hiding real errors - is eInfo expected to be N
Yes, if a disk disappears - hotunplug being the easiest case I think. A disk disappearing is most likely the cause of the issue you faced - can you describe the flow so I can test this fix?
Line 543:                         vmDrive.name in sInfo and vmDrive.name in eInfo):
Line 544:                     # will be None if sampled during recovery
Line 545:                     dStats.update(self._calcDiskRate(vmDrive, sInfo, eInfo,
Line 546:                                                      sampleInterval))


Line 539:                     dStats['imageID'] = vmDrive.imageID
Line 540:                 elif "GUID" in vmDrive:
Line 541:                     dStats['lunGUID'] = vmDrive.GUID
Line 542:                 if sInfo is not None and eInfo is not None and (
Line 543:                         vmDrive.name in sInfo and vmDrive.name in eInfo):
> The original code had unneeded parenthesis around the last two checks - thi
No big deal aout the first two cleanups, will push them.
Line 544:                     # will be None if sampled during recovery
Line 545:                     dStats.update(self._calcDiskRate(vmDrive, sInfo, eInfo,
Line 546:                                                      sampleInterval))
Line 547:             except (AttributeError, TypeError, ZeroDivisionError):


-- 
To view, visit http://gerrit.ovirt.org/33482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list