Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 30 09:44:10 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/33492/4/vdsm/storage/vdsm-lvm.rules.in
File vdsm/storage/vdsm-lvm.rules.in:

Line 20: # The libvirt image label is required to allow qemu to access volumes. Libvirt
Line 21: # sets this label on volumes when starting a vm, but on recent EL and Fedora
Line 22: # releases, the label is lost after refreshing a logical volume, and vm get
Line 23: # paused. This rule ensures that the label exist after device changes. See
Line 24: # https://bugzilla.redhat.com/1127460
> What's the bz of the underlying component?
That bz does not exists yet, since we don't know what is the underlying component responsible for this. I think libvirt is the right component, as they manage the label.
Line 25: #
Line 26: # TODO: use SECLABEL{selinux}="@LIBVIRT_IMAGE_LABEL@" when this syntax is
Line 27: # supported. See https://bugzilla.redhat.com/1015300
Line 28: 


-- 
To view, visit http://gerrit.ovirt.org/33492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list