Change in vdsm[master]: use with statement to take care of unclosed files

ybronhei at redhat.com ybronhei at redhat.com
Tue Sep 30 07:49:35 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: use with statement to take care of unclosed files
......................................................................


Patch Set 1: Code-Review+1

did you try "grep '.read()' /usr/share/vdsm/*" and see that you covered all the open calls ?

-- 
To view, visit http://gerrit.ovirt.org/31717
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c33b22aa9828245c4598622ae6870f13b797036
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list