Change in vdsm[master]: vm: Fix error with missing cdrom in conf

danken at redhat.com danken at redhat.com
Mon Sep 29 22:34:40 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: Fix error with missing cdrom in conf
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33501/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-09-29 13:17:02 -0300
Line 6: 
Line 7: vm: Fix error with missing cdrom in conf
Line 8: 
Line 9: Avoids referencing the cdrom parameter in conf in case it is missing.
Please try to find out what triggered this issue on Engine's side, since this code in Vdsm is ancient. We need this research in order to asses whether (and how far) should this fix be backported.

Hence my former question: Would this affect only 3.5, or also older Vdsm's?
Line 10: 
Line 11: Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728


-- 
To view, visit http://gerrit.ovirt.org/33501
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list