Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...

danken at redhat.com danken at redhat.com
Mon Sep 29 20:10:02 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.ovirt.org/#/c/31529/15/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 559:                            session.id))
Line 560:                 return
Line 561: 
Line 562:         supervdsm.getProxy().setRpFilter(sessionInfo.iface.netIfacename,
Line 563:                                          _SYSCTL_RPFILTER_STRICT)
> The problem with this approach is the fact we may have several sessions usi
Yes, I agree to this simplification. We should add a release note in the BZ, that if an interface is used by ovirt storage it may loose its original rpfilter setting.


-- 
To view, visit http://gerrit.ovirt.org/31529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: jian wang <wjian84 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list