Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
danken at redhat.com
danken at redhat.com
Mon Sep 29 20:00:55 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates
......................................................................
Patch Set 2:
(1 comment)
for this record: I failed to publish this comment on time due to a race with a new patchset.
http://gerrit.ovirt.org/#/c/33411/2/vdsm_reg/deployUtil.py.in
File vdsm_reg/deployUtil.py.in:
Line 1121: [os.path.join(vdsmDir, SCRIPT_NAME_GET_CONFIG),
Line 1122: P_VDSM_CONF, 'vars', 'net_persistence', 'ifcfg'])
Line 1123: if ret:
Line 1124: raise Exception('Failed to retrieve vdsm persistence '
Line 1125: 'mode. Stderr: %s', err)
You have to parse "out": "ret" is a plain int afair.
In "parse" I mean "drop final newline".
Line 1126:
Line 1127: out, err, ret = _logExec(
Line 1128: [os.path.join(vdsmDir, SCRIPT_NAME_STORE_NET_CONFIG), ret])
Line 1129: if ret:
--
To view, visit http://gerrit.ovirt.org/33411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list