Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...

danken at redhat.com danken at redhat.com
Mon Sep 29 18:17:16 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/33492/3//COMMIT_MSG
Commit Message:

Line 22: We don't know why the selinux label is lost, and lvm developers claim
Line 23: that relevant code was not changed recently. This issue may be caused by
Line 24: lower level components such as device mapper, multipath or iscsi.
Line 25: 
Line 26: This patch adds a temporary solution, by updating vdsm lvm rules to set
It's either a libvirt bug, or something lower in the stack - but we need a BZ open to track this (or else it would be forgotten, or solved without us noticing).

It's libvirt's responsibility to set a label that is maintained over refreshes. What they currently do is buggy. Please pass the buck when level downwards.
Line 27: the libvirt image selinux label on vdsm images.
Line 28: 
Line 29: Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Line 30: Bug-Url: https://bugzilla.redhat.com/1127460


-- 
To view, visit http://gerrit.ovirt.org/33492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list