Change in vdsm[master]: vm: Fix error with missing cdrom in conf

vdelima at redhat.com vdelima at redhat.com
Mon Sep 29 16:21:30 UTC 2014


Vitor de Lima has uploaded a new change for review.

Change subject: vm: Fix error with missing cdrom in conf
......................................................................

vm: Fix error with missing cdrom in conf

Avoids referencing the cdrom parameter in conf in case it is missing.

Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728
Signed-off-by: Vitor de Lima <vdelima at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/33501/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ad8cb0e..c3bb7cf 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4389,7 +4389,9 @@
             return {'status': {'code': errCode['changeDisk']['status']['code'],
                                'message': errCode['changeDisk']['status']
                                                  ['message']}}
-        self.cif.teardownVolumePath(self.conf.get(vmDev))
+        if vmDev in self.conf:
+            self.cif.teardownVolumePath(self.conf[vmDev])
+
         self.conf[vmDev] = path
         return {'status': doneCode, 'vmList': self.status()}
 


-- 
To view, visit http://gerrit.ovirt.org/33501
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>


More information about the vdsm-patches mailing list