Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...

danken at redhat.com danken at redhat.com
Mon Sep 29 16:02:40 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/33492/2//COMMIT_MSG
Commit Message:

Line 22: We don't know why the selinux label is lost, and lvm developers claim
Line 23: that relevant code was not changed recently. This issue may be caused by
Line 24: lower level components such as device mapper, multipath or iscsi.
Line 25: 
Line 26: This patch adds a temporary solution, by updating vdsm lvm rules to set
Can we reproduce the label removal with

  lvchange --refresh

outside the context of vdsm? IPlease open such a BZ and refer to it in this commit message. If we do not do that, we would never recall to remove the superfluous `chcon` added here.

BTW, can we avoid the chcons on el6 (without adding too much complexity)? It's a shame to affect our main platform with plenty of execs that it does not need.
Line 27: the libvirt image selinux label on vdsm images.
Line 28: 
Line 29: Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Line 30: Bug-Url: https://bugzilla.redhat.com/1127460


-- 
To view, visit http://gerrit.ovirt.org/33492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list