Change in vdsm[master]: vm: Fix error with missing cdrom in conf

danken at redhat.com danken at redhat.com
Mon Sep 29 15:41:56 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: Fix error with missing cdrom in conf
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/33495/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-09-29 12:29:36 -0300
Line 6: 
Line 7: vm: Fix error with missing cdrom in conf
Line 8: 
Line 9: Avoids referencing the cdrom parameter in conf in case it is missing.
Do you have any guess why this has suddenly become an issue? The code here is quite ancient.

Is it a new behavior of Engine to send conf with no cdrom? Would this affect only 3.5, or also older Vdsm's?
Line 10: 
Line 11: Change-Id: If33afdd7069d65bf8a6a34725924ccac38c35b3b
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728


Line 7: vm: Fix error with missing cdrom in conf
Line 8: 
Line 9: Avoids referencing the cdrom parameter in conf in case it is missing.
Line 10: 
Line 11: Change-Id: If33afdd7069d65bf8a6a34725924ccac38c35b3b
Please use the same Change-Id for master and stable brances.

Change-Id is the identifier telling me (and automated scripts) that the patches are doing "the same thing".
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728


-- 
To view, visit http://gerrit.ovirt.org/33495
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33afdd7069d65bf8a6a34725924ccac38c35b3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list