Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf

vdelima at redhat.com vdelima at redhat.com
Mon Sep 29 15:23:00 UTC 2014


Vitor de Lima has posted comments on this change.

Change subject: vm: Fix error with missing cdrom in conf
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/33472/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-09-29 09:04:08 -0300
Line 6: 
Line 7: vm: Fix error with missing cdrom in conf
Line 8: 
Line 9: Avoids referencing the cdrom parameter in conf in case it is missing.
> Could you explain the issue, and why did it suddenly pop up?
The referred bug shows that while using JSON-RPC, there were two different problems: the first, in the engine code, was solved by change #33471 and the second was a reference to the missing cdrom key in self.conf while changing a cdrom of a running VM configured to run without a initial CD attached to it.

Other places in the VDSM code check for the existence of this key before handling it.


I will send it to master ASAP.
Line 10: 
Line 11: Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728


http://gerrit.ovirt.org/#/c/33472/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4709:             return {'status': {'code': errCode['changeDisk']['status']['code'],
Line 4710:                                'message': errCode['changeDisk']['status']
Line 4711:                                                  ['message']}}
Line 4712:         if vmDev in self.conf:
Line 4713:             self.cif.teardownVolumePath(self.conf.get(vmDev))
> Since we now know that vmDev is in conf, we'd better use
Done
Line 4714: 
Line 4715:         self.conf[vmDev] = path
Line 4716:         return {'status': doneCode, 'vmList': self.status()}
Line 4717: 


-- 
To view, visit http://gerrit.ovirt.org/33472
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list