Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...

danken at redhat.com danken at redhat.com
Mon Sep 29 15:09:24 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33489/1/tests/netinfoTests.py
File tests/netinfoTests.py:

Line 353:         self.assertNotIn('expired2', dhcp4)
Line 354: 
Line 355:     @ValidateRunningAsRoot
Line 356:     # TODO: backport 'netinfo_tests: load bonding module for Centos7' first
Line 357:     # @RequireBondingMod
this patch only renames the function. It does no functional change. So this TODO is unrelated to this patch. Please drop it.

If you want to backport @RequireBondingMod, you can suggest it in another patch..
Line 358:     def testGetBondingOptions(self):
Line 359:         INTERVAL = '12345'
Line 360:         bondName = _random_iface_name()
Line 361: 


-- 
To view, visit http://gerrit.ovirt.org/33489
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92bcf62a4ae1756b0d2857cc0c7387c128f9b8a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list