Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...

danken at redhat.com danken at redhat.com
Mon Sep 29 14:55:07 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/33411/3/vdsm_reg/deployUtil.py.in
File vdsm_reg/deployUtil.py.in:

Line 1124:                     raise Exception('Failed to retrieve vdsm persistence '
Line 1125:                                     'mode. Stderr: %s' % err)
Line 1126: 
Line 1127:                 out, err, ret = _logExec(
Line 1128:                     [os.path.join(vdsmDir, SCRIPT_NAME_STORE_NET_CONFIG), ret])
the command line should have "out" (with newline dropped), not "ret"
Line 1129:                 if ret:
Line 1130:                     raise Exception('Failed to persist vdsm networking '
Line 1131:                                     'configuration. Stderr: %s' % err)
Line 1132:             else:


-- 
To view, visit http://gerrit.ovirt.org/33411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list