Change in vdsm[master]: jsonrpc: Report properly response None type

danken at redhat.com danken at redhat.com
Mon Sep 29 14:09:39 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: Report properly response None type
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33484/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 282:             ret = dict([(key, value) for key, value in result.items()
Line 283:                         if key is not 'status'])
Line 284:         else:
Line 285:             ret = self._getResult(result, retfield)
Line 286:         if ret is None:
does all other value of "ret" are valid? why single-out the None value?

Logging the value of "ret" in case of _fixupRet() error is a good idea, but I am not sure what is the benefit of this specific new exception.
Line 287:             raise yajsonrpc.JsonRpcInvalidResponseType()
Line 288:         return self._fixupRet(className, methodName, ret)
Line 289: 
Line 290: 


-- 
To view, visit http://gerrit.ovirt.org/33484
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list