Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf
danken at redhat.com
danken at redhat.com
Mon Sep 29 13:34:00 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Fix error with missing cdrom in conf
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33472/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4709: return {'status': {'code': errCode['changeDisk']['status']['code'],
Line 4710: 'message': errCode['changeDisk']['status']
Line 4711: ['message']}}
Line 4712: if vmDev in self.conf:
Line 4713: self.cif.teardownVolumePath(self.conf.get(vmDev))
Since we now know that vmDev is in conf, we'd better use
self.conf[vmDev]
Line 4714:
Line 4715: self.conf[vmDev] = path
Line 4716: return {'status': doneCode, 'vmList': self.status()}
Line 4717:
--
To view, visit http://gerrit.ovirt.org/33472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list