Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...

osvoboda at redhat.com osvoboda at redhat.com
Mon Sep 29 11:28:10 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
......................................................................


Patch Set 13:

(3 comments)

http://gerrit.ovirt.org/#/c/33403/13/debian/vdsm.install
File debian/vdsm.install:

Line 155: ./usr/share/vdsm/virt/vmstatus.py
Line 156: ./usr/share/vdsm/virt/vmxml.py
Line 157: ./usr/share/vdsm/virt/utils.py
Line 158: ./var/lib/polkit-1/localauthority/10-vendor.d/10-vdsm-libvirt-access.pkla
Line 159: ./var/lib/vdsm/bonding-defaults.json
> put that in line 26. later on we'll move 158 also near the /var/lib files
Done


http://gerrit.ovirt.org/#/c/33403/13/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:

Line 235:     --pre-start)
Line 236:         # If dump_bonding_defaults is desired (for the uneliminable possibility
Line 237:         # of added bonding options or tweaked kernel defaults) it has to be run
Line 238:         # after load_needed_modules (modprobe bonding).
Line 239:         # NetworkManager must not crash on nmcli conn delete.
> Actually, the commit message says that we are NOT advised to run it on star
This is just a note on the required ordering if we ever run dump_bonding_defaults on startup.
Line 240:         run_tasks " \
Line 241:             mkdirs \
Line 242:             configure_coredump \
Line 243:             configure_vdsm_logs \


http://gerrit.ovirt.org/#/c/33403/13/lib/vdsm/tool/dump_bonding_defaults.py
File lib/vdsm/tool/dump_bonding_defaults.py:

Line 1: #! /usr/bin/env python
> Yaniv is right - the #! line is not needed.
dummybr had it, plus the invocation of the main() function. As I documented in the commit message, 'vdsm-tool dump-bonding-defaults' is the preferred way of running the tool so I will get rid of the if __name__ == '__main__' too.
Line 2: # Copyright 2014 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


-- 
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list