Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...

danken at redhat.com danken at redhat.com
Mon Sep 29 10:46:19 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.ovirt.org/#/c/33403/13/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:

Line 235:     --pre-start)
Line 236:         # If dump_bonding_defaults is desired (for the uneliminable possibility
Line 237:         # of added bonding options or tweaked kernel defaults) it has to be run
Line 238:         # after load_needed_modules (modprobe bonding).
Line 239:         # NetworkManager must not crash on nmcli conn delete.
> in the commit message you say that you call it, but you didn't add it to th
Actually, the commit message says that we are NOT advised to run it on startup.

 It is currently not advised to run the tool on startup because NetworkManager
 may ifup the reference bond, making the tool unable to determine all options.
Line 240:         run_tasks " \
Line 241:             mkdirs \
Line 242:             configure_coredump \
Line 243:             configure_vdsm_logs \


-- 
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list