Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...

osvoboda at redhat.com osvoboda at redhat.com
Mon Sep 29 09:51:06 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
......................................................................


Patch Set 12: Verified+1

Prettified the JSON for easier comparison, referred to the ' NetworkManager ifups VDSM's reference bond' bug.

Only unit testMirroringWithDistraction failed with

 CalledProcessError: Command '['/usr/sbin/brctl', 'delbr', 'vdsmtest-wSe0P']' returned non-zero exit status 1

this time (the bridge was still up).

Functional testSetupNetworksOverDhcpIface failed on

 ipv4addr, prefix = addr['address'].split('/')

with ValueError: need more than 1 value to unpack. I believe this is unrelated and will try to find out the source of this test failure.

-- 
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list