Change in vdsm[master]: tests: Add tests for qcow2 comapt option when converting images

danken at redhat.com danken at redhat.com
Mon Sep 29 09:42:44 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Add tests for qcow2 comapt option when converting images
......................................................................


tests: Add tests for qcow2 comapt option when converting images

Since qemuimg.convert() uses utils.watchCmd instead of utils.execCmd,
FakeExecCmd was modified so it can patch both functions.

This patch is separate from the actual fix, to allow easy backporting of
the actual fix, without backporing the testing infrastructure, which is
missing in older versions.

Change-Id: I0d19b59bf4880e20f53369c79ae34386d274915d
Relates-To: https://bugzilla.redhat.com/1139707
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33350
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M tests/qemuimgTests.py
1 file changed, 83 insertions(+), 33 deletions(-)

Approvals:
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33350
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d19b59bf4880e20f53369c79ae34386d274915d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list