Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...

danken at redhat.com danken at redhat.com
Fri Sep 26 20:20:08 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33411/1//COMMIT_MSG
Commit Message:

Line 21: 
Line 22: In order to solve this issue, the best course of action is to
Line 23: persist RunningConfig as PersistentConfig as soon as the management
Line 24: network has been created by vdsm-reg (and strictly before the
Line 25: registration request is sent to the engine).
> I didn't want vdsm-reg to depend on lib/vdsm/config.py for getting which pe
Since vdsm-reg edits vdsm.conf, your worries are well-placed. But with your patch, we reach a very confusing state, of two almost-identical scripts available for persisting net config.

I need some doc help to understand the difference between the two (user-wise), and realize why we need to keep both of them.
Line 26: 
Line 27: Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Line 28: Bug-Url: https://bugzilla.redhat.com/1144639


-- 
To view, visit http://gerrit.ovirt.org/33411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list