Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...

danken at redhat.com danken at redhat.com
Fri Sep 26 20:06:57 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.ovirt.org/#/c/31529/15/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 1134:     flags |= os.O_NONBLOCK
Line 1135:     fcntl.fcntl(fd, fcntl.F_SETFL, flags)
Line 1136: 
Line 1137: 
Line 1138: def setRpFilter(dev, mode):
Please use new-style function names for new functions in this module.

 set_rp_filter()
Line 1139:     try:
Line 1140:         path = '/proc/sys/net/ipv4/conf/%s/rp_filter' % dev
Line 1141:         with open(path, 'w') as rp_filter:
Line 1142:             rp_filter.write(mode)


-- 
To view, visit http://gerrit.ovirt.org/31529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list