Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
danken at redhat.com
danken at redhat.com
Fri Sep 26 18:32:01 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
......................................................................
Patch Set 7: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/33403/7/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 100: }
Line 101:
Line 102:
Line 103: task_dump_bonding_defaults(){
Line 104: "${VDSM_TOOL}" dump-bonding-defaults
please do not run this on startup - NM may be around. instead, ship the defaults within the git tree and tarball.
Line 105: }
Line 106:
Line 107:
Line 108: task_tune_system(){
http://gerrit.ovirt.org/#/c/33403/7/lib/vdsm/tool/dump_bonding_defaults.py
File lib/vdsm/tool/dump_bonding_defaults.py:
Line 27: bondOpts, realBondOpts)
Line 28: from . import expose, ExtraArgsError
Line 29:
Line 30:
Line 31: def _randomIfaceName():
Sorry to nag, but in new modules, please use newer-style function and variable names such as
_random_iface_name()
Line 32: MAX_LENGTH = 15
Line 33: CHARS = string.ascii_lowercase + string.ascii_uppercase + string.digits
Line 34:
Line 35: return ''.join(random.choice(CHARS) for _ in range(MAX_LENGTH))
--
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list