Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...

danken at redhat.com danken at redhat.com
Fri Sep 26 16:54:40 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/33411/1//COMMIT_MSG
Commit Message:

Line 21: 
Line 22: In order to solve this issue, the best course of action is to
Line 23: persist RunningConfig as PersistentConfig as soon as the management
Line 24: network has been created by vdsm-reg (and strictly before the
Line 25: registration request is sent to the engine).
Could you explain why we'd better add a new vdsm-tool command instead of using the existing /usr/share/vdsm/vdsm-store-net-config script?

(And if add the command, why keep the script?)
Line 26: 
Line 27: Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Line 28: Bug-Url: https://bugzilla.redhat.com/1144639


http://gerrit.ovirt.org/#/c/33411/1/vdsm_reg/deployUtil.py.in
File vdsm_reg/deployUtil.py.in:

Line 995: 
Line 996: 
Line 997: def setSafeVdsmNetworkConfig():
Line 998:     """consider current network configuration as safe and remove its backup"""
Line 999:     out, err, ret = _logExec([os.path.join(P_USR_BIN, 'vdsm-tool'),
puritanically speaking, this module is supposed to be shipped to rhev-m-3.0 users (if the still exist) and as such - it should maintain the ancient backward compatibility code which is deleted here.
Line 1000:                              'store-nets'])
Line 1001:     if ret:
Line 1002:         raise Exception('Failed to store network. Stderr: %s' % err)
Line 1003: 


Line 1106:             )
Line 1107: 
Line 1108:     # Save current config by removing the undo files:
Line 1109:     try:
Line 1110:         if fReturn:
... so maybe it's safer to limit the new logic to fIsOvirt==True
Line 1111:             setSafeVdsmNetworkConfig()
Line 1112:     except:
Line 1113:         logging.debug(traceback.format_exc())
Line 1114: 


-- 
To view, visit http://gerrit.ovirt.org/33411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list