Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...

osvoboda at redhat.com osvoboda at redhat.com
Fri Sep 26 16:53:52 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/33403/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-09-26 15:16:23 +0200
Line 4: Commit:     Ondřej Svoboda <osvoboda at redhat.com>
Line 5: CommitDate: 2014-09-26 17:44:28 +0200
Line 6: 
Line 7: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
> this patch would be much simpler if it did not depend on the complex NM-rel
Okay, I will first push some fixes and then split the patch.
Line 8: 
Line 9: Change-Id: I89b907ba80f23f417d5e481db9350247445ab772


http://gerrit.ovirt.org/#/c/33403/2/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 87: P_VDSM_LOG = '@VDSMLOGDIR@'
Line 88: P_VDSM_NODE_ID = '/etc/vdsm/vdsm.id'
Line 89: 
Line 90: P_VDSM_EXEC = '@LIBEXECDIR@'
Line 91: P_VDSM_BONDING_DEFAULTS = P_VDSM_LIB + 'bonding-defaults.json'
> contants.py is a junk yard. this new constant is very specific and it fits 
I am sorry but in order to avoid circular dependency I have to put it to a place that both netinfo and the tool can import from.
Line 92: 
Line 93: #
Line 94: # Configuration file definitions
Line 95: #


-- 
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list