Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images when converting exi...
nsoffer at redhat.com
nsoffer at redhat.com
Fri Sep 26 14:49:15 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Create qcow2 compat 0.10 images when converting existing images
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/33349/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 149: available on all platforms.
Line 150: """
Line 151: # Older qemu-img requires all filenames although unneeded
Line 152: flag, dummy_files = {"create": ("-f", ("dst",)),
Line 153: "convert": ("-O", ("src", "dst"))}[command]
> I liked /dev/null better, any problem with those?
/dev/null is ok
Line 154:
Line 155: cmd = [_qemuimg.cmd, command, flag, FORMAT.QCOW2, "-o", "?"]
Line 156: cmd.extend(dummy_files)
Line 157:
--
To view, visit http://gerrit.ovirt.org/33349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list