Change in vdsm[ovirt-3.5]: spec: do not require qemu-kvm-rhev on Fedora

danken at redhat.com danken at redhat.com
Fri Sep 26 13:34:14 UTC 2014


Hello Federico Simoncelli,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/33407

to review the following change.

Change subject: spec: do not require qemu-kvm-rhev on Fedora
......................................................................

spec: do not require qemu-kvm-rhev on Fedora

qemu-kvm-rhev is required for oVirt's feature completeness. However it
is not shipped within Fedora. When Vdsm is built for Fedora, we cannot
require it. However, when built for oVirt and downstream RHEV, it is
simpler and nicer to have a strict hard requirement.

Change-Id: If272983362d5b0f11d0925c64315a046d3b144d0
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33367
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm.spec.in
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/33407/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index a00f68c..ca2e86f 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -214,13 +214,17 @@
 Requires: systemd >= 197-1.fc18.2
 %endif
 
+%if !%{fedora_koji_build}
+%global rhev_suffix -rhev
+%endif
+
 %if 0%{?rhel}
 %if 0%{?rhel} >= 7
-Requires: qemu-kvm-rhev
-Requires: qemu-img-rhev
+Requires: qemu-kvm%{?rhev_suffix}
+Requires: qemu-img%{?rhev_suffix}
 %else
-Requires: qemu-kvm-rhev >= 2:0.12.1.2-2.415.el6_5.3
-Requires: qemu-img-rhev >= 2:0.12.1.2-2.415.el6_5.3
+Requires: qemu-kvm%{?rhev_suffix} >= 2:0.12.1.2-2.415.el6_5.3
+Requires: qemu-img%{?rhev_suffix} >= 2:0.12.1.2-2.415.el6_5.3
 %endif
 %else
 Requires: qemu-kvm >= 2:0.15.0-4


-- 
To view, visit http://gerrit.ovirt.org/33407
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If272983362d5b0f11d0925c64315a046d3b144d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list